Identifying layers to convert to LoRA by pattern or indicating all linear layers #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `should_convert_to_lora` to generalize deciding whether or not to convert a layer to LoRA. It is used by `linear_to_lora_layers`, which is updated to indicate all linear layers are converted if any of the keys are "all". Otherwise, the layers indicated by their keys are converted to LoRa
Print converted layers if matched by key_patterns or "all"
chimezie
changed the title
Contributor
|
Nice one!!! |
angeloskath
requested changes
Jun 16, 2025
Member
angeloskath
left a comment
angeloskath
left a comment
There was a problem hiding this comment.
This is nice! I left a few beautification comments and one bug but after that we can merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for matching layers to convert to LoRa by REGEX patterns:
Or by specifying "all" in any of the keys to indicate converting all linear layers to LoRa:
In either case, the keys of the converted layers are also printed for reference.